Skip to content

[DependencyInjection] Add a note about constructor promotion and IDEs errors about attributes #18813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

javiereguiluz
Copy link
Member

Fixes #18071.

I propose to include the full error message shown by the IDE so it's easier to find this when googling about the error.

@javiereguiluz javiereguiluz added this to the 5.4 milestone Sep 1, 2023
@carsonbot carsonbot changed the title Add a note about constructor promotion and IDEs errors about attributes [DependencyInjection] Add a note about constructor promotion and IDEs errors about attributes Sep 1, 2023
@OskarStark
Copy link
Contributor

We should check if there is an open bug report for some major IDE, e.g. PHPStorm and link it

@javiereguiluz
Copy link
Member Author

There is a bug report for PhpStorm (here: https://youtrack.jetbrains.com/issue/WI-59609).

But, as you can read, they say that they do the same as PHP and don't know how to solve this or even if it can be solved. Because of this, I guess it will happen to all IDEs, so I'd prefer to not link to a specific IDE. Thanks.

@javiereguiluz javiereguiluz merged commit aa73335 into symfony:5.4 Sep 4, 2023
@javiereguiluz javiereguiluz deleted the fix_18071 branch September 4, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants